Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to publish a release on every push to develop. #1261

Merged
merged 1 commit into from
Sep 1, 2018

Conversation

NodeGuy
Copy link
Contributor

@NodeGuy NodeGuy commented Aug 31, 2018

Closes #1177

Description:

❤️ Thank you!

@NodeGuy NodeGuy requested review from faboweb and nylira as code owners August 31, 2018 22:26
@codecov
Copy link

codecov bot commented Aug 31, 2018

Codecov Report

Merging #1261 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1261   +/-   ##
========================================
  Coverage    95.86%   95.86%           
========================================
  Files           80       80           
  Lines         1598     1598           
  Branches        75       75           
========================================
  Hits          1532     1532           
  Misses          60       60           
  Partials         6        6

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fedekunze fedekunze merged commit 40464b4 into develop Sep 1, 2018
@NodeGuy NodeGuy deleted the david/1177-donotpublish branch September 4, 2018 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not run publish step every time
2 participants