Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fresh 0.6.0 bugs 🐛🐜🐞 #720

Closed
jbibla opened this issue May 18, 2018 · 6 comments · Fixed by #752
Closed

fresh 0.6.0 bugs 🐛🐜🐞 #720

jbibla opened this issue May 18, 2018 · 6 comments · Fixed by #752
Assignees
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed

Comments

@jbibla
Copy link
Collaborator

jbibla commented May 18, 2018

Thank you for filing an issue!

Version

v0.6.0

Description

noticed a few issues right off the bat

  • first time i opened the app, created a new account, was still on gaia-5000, had to quit and restart app to get to gaia-5001
  • fresh install, create new account, sign out - account will not be there to sign back in until you restart the app
  • clicking on the mocked option in settings worked nicely, but unclicking does not set network back to gaia-5001
  • sign out while in mocked mode goes to sign in screen - but account doesn't exist on mocked server (confusing ux) - also shows network error: keys on sign out
  • if available balance is 0 - loading screen persists unless you hit refresh
  • link to staking is still visible - and route still works (supposed to be hidden)
  • onboarding tutorial checkbox takes you back to onboarding modals when trying to mark it as completed
@NodeGuy
Copy link
Contributor

NodeGuy commented May 21, 2018

  • first time i opened the app, created a new account, was still on gaia-5000, had to quit and restart app to get to gaia-5001

To attempt reproduction I deleted my ~./cosmos-voyager-dev directory and downgraded to 0.5.0. It doesn't get past the "COMOS VOYAGER app is loading..." page.

  • fresh install, create new account, sign out - account will not be there to sign back in until you restart the app

I couldn't recreate this. The account was there for me without restarting.

  • clicking on the mocked option in settings worked nicely, but unclicking does not set network back to gaia-5001

Fixed in #723.

  • sign out while in mocked mode goes to sign in screen - but account doesn't exist on mocked server (confusing ux) - also shows network error: keys on sign out

If I sign out I am asked for the password for the default account. I enter 1234567890 and it works as expected. Perhaps this is a documentation bug?

I don't see "network error: keys" on sign out.

  • if available balance is 0 - loading screen persists unless you hit refresh

On my screen I see N/A No data available yet. Refreshing sends a request to http://localhost:9070/accounts/F063EA013CDE9EED4550CBDFA8EEF3EDFAA440C2 which returns 204 No Content.

  • link to staking is still visible - and route still works (supposed to be hidden)

Fixed in #723.

  • onboarding tutorial checkbox takes you back to onboarding modals when trying to mark it as completed

This is a known bug (#669) with unclear resolution.

@nylira
Copy link
Contributor

nylira commented May 22, 2018

  • onboarding tutorial checkbox takes you back to onboarding modals when trying to mark it as completed

The bug where the onboarding tutorial shows up after every app restart has been fixed in #717 This resolves the root of this problem.

The settings checkbox for onboarding isn't for marking it completed. It's for toggling it, like the other checkboxes. Checkboxes are not the correct UX, which is mentioned in #669

@faboweb
Copy link
Collaborator

faboweb commented May 22, 2018

Staking doesn't show:
image

@faboweb
Copy link
Collaborator

faboweb commented May 22, 2018

Thank you guys for finding and following up on all those bugs! Great teamwork :)

@faboweb faboweb added the bug 🐛 issues related to unhandled errors in the code that need to be fixed label May 22, 2018
@faboweb
Copy link
Collaborator

faboweb commented May 24, 2018

Do any of these bugs remain? @jolesbi

@jbibla
Copy link
Collaborator Author

jbibla commented May 25, 2018

i tested these bugs out and all look cleared up except for the one i didn't describe very well. i'll fix it now.

jbibla added a commit that referenced this issue May 25, 2018
few small updates to address the last release
faboweb pushed a commit that referenced this issue Jun 2, 2020
* fix kusama overview totalstake fiatvalue

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants