Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve button design #203

Closed
5 tasks done
nylira opened this issue Dec 8, 2017 · 4 comments · Fixed by #426
Closed
5 tasks done

Improve button design #203

nylira opened this issue Dec 8, 2017 · 4 comments · Fixed by #426
Assignees
@nylira
Labels
design-work-needed 🎨 issues that require design work before development

Comments

@nylira
Copy link
Contributor

nylira commented Dec 8, 2017 •
edited
Loading

We need a good primary button design with (most likely) a full color background using our link color.

We need an danger! button design using the danger color for serious actions like deleting an account.

The default button height of 2rem looks too small on desktop, consider increasing button height to 2.5rem by default?

  • primary button color
  • success button color
  • warning button color
  • danger button color
  • fix button overflow issue
@nylira nylira self-assigned this Dec 8, 2017
@jbibla
Copy link
Collaborator

jbibla commented Dec 8, 2017

i agree 100%!!!

@faboweb
Copy link
Collaborator

faboweb commented Dec 8, 2017

Sounds good.

@nylira nylira added the design-work-needed 🎨 issues that require design work before development label Dec 11, 2017
@nylira
Copy link
Contributor Author

nylira commented Jan 15, 2018 •
edited
Loading

I'm not a fan of the primary button currently:

screen shot 2018-01-15 at 12 53 13 pm

The background and outer border look washed out compared to the rest of the app. Let's improve this.

@jbibla
Copy link
Collaborator

jbibla commented Jan 15, 2018

please improve! just wanted to make sure the primary was there.

@nylira nylira mentioned this issue Feb 1, 2018
Merged
faboweb added a commit that referenced this issue Jun 2, 2020
@faboweb
Fabo/fix styling (#203)
ecafb78 
* always use cheap source maps

* remove e2e tests for now

* changelog

* fix session approve styling

* changelog

* missing commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nylira nylira

Labels
design-work-needed 🎨 issues that require design work before development
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Peng/203 improve buttons luniehq/lunie
3 participants
@nylira @faboweb @jbibla