removed page preferences; closes #2259

luniehq · Mar 13, 2019 · 67d3d39 · 67d3d39
1 parent e08f1b7
commit 67d3d39
Show file tree

Hide file tree

Showing 9 changed files with 2 additions and 296 deletions.
diff --git a/app/src/renderer/components/common/PagePreferences.vue b/app/src/renderer/components/common/PagePreferences.vue
diff --git a/app/src/renderer/components/common/ToolBar.vue b/app/src/renderer/components/common/ToolBar.vue
@@ -9,9 +9,6 @@
       <i v-tooltip.bottom="'Refresh'" class="material-icons">refresh</i>
     </a>
     <slot />
-    <router-link v-if="session.signedIn" id="settings" to="/preferences">
-      <i v-tooltip.bottom="'Preferences'" class="material-icons">settings</i>
-    </router-link>
     <a
       v-if="session.signedIn"
       id="signOut-btn"

diff --git a/app/src/renderer/routes.js b/app/src/renderer/routes.js
@@ -60,12 +60,6 @@ export default [
     name: `validator`,
     component: require(`./components/staking/PageValidator`).default
   },
-  {
-    path: `/preferences`,
-    name: `preferences`,
-    component: require(`./components/common/PagePreferences`).default,
-    meta: { requiresAuth: true }
-  },
   {
     path: `/wallet`,
     name: `wallet`,

diff --git a/test/e2e/common.js b/test/e2e/common.js
@@ -59,21 +59,14 @@ module.exports = {
     })
     console.log(`navigated to "${linkText}"`)
   },
-  async navigateToPreferences(app) {
-    await module.exports.openMenu(app)
-    // click link
-    await app.client.waitForExist(`#settings`, 1000)
-    await app.client.$(`#settings`).click()
-    console.log(`navigated to preferences`)
-  },
   sleep,
   async waitForText(elGetterFn, text, timeout = 5000) {
     const start = Date.now()
     while ((await elGetterFn().getText()) !== text) {
       if (Date.now() - start >= timeout) {
         throw Error(
           `Timed out waiting for text. Expected ${text}, Showing ${(await elGetterFn().getText()) ||
-            `nothing`}`
+          `nothing`}`
         )
       }
       await sleep(100)
@@ -85,7 +78,7 @@ module.exports = {
       if (Date.now() - start >= timeout) {
         throw Error(
           `Timed out waiting for value. Expected ${value}, Showing ${(await elGetterFn().getValue()) ||
-            `nothing`}`
+          `nothing`}`
         )
       }
       await sleep(100)

diff --git a/test/e2e/preferences.js b/test/e2e/preferences.js
diff --git a/test/unit/specs/components/common/PagePreferences.spec.js b/test/unit/specs/components/common/PagePreferences.spec.js
diff --git a/test/unit/specs/components/common/__snapshots__/PagePreferences.spec.js.snap b/test/unit/specs/components/common/__snapshots__/PagePreferences.spec.js.snap
diff --git a/test/unit/specs/components/common/__snapshots__/ToolBar.spec.js.snap b/test/unit/specs/components/common/__snapshots__/ToolBar.spec.js.snap
@@ -6,17 +6,6 @@ exports[`ToolBar has the expected html structure 1`] = `
 >
   <!---->
     
-  <router-link-stub
-    id="settings"
-    to="/preferences"
-  >
-    <i
-      class="material-icons"
-    >
-      settings
-    </i>
-  </router-link-stub>
-   
   <a
     id="signOut-btn"
   >

diff --git a/test/unit/specs/components/governance/__snapshots__/PageGovernance.spec.js.snap b/test/unit/specs/components/governance/__snapshots__/PageGovernance.spec.js.snap
@@ -28,17 +28,6 @@ exports[`PageGovernance disables proposal creation if not connected 1`] = `
           >
             <!---->
               
-            <router-link-stub
-              id="settings"
-              to="/preferences"
-            >
-              <i
-                class="material-icons"
-              >
-                settings
-              </i>
-            </router-link-stub>
-             
             <a
               id="signOut-btn"
             >
@@ -150,17 +139,6 @@ exports[`PageGovernance has the expected html structure 1`] = `
           >
             <!---->
               
-            <router-link-stub
-              id="settings"
-              to="/preferences"
-            >
-              <i
-                class="material-icons"
-              >
-                settings
-              </i>
-            </router-link-stub>
-             
             <a
               id="signOut-btn"
             >