Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tabs): implement the component according to 1.2.1 DS version #1145

Merged
merged 1 commit into from
Feb 21, 2020
Merged

feat(tabs): implement the component according to 1.2.1 DS version #1145

merged 1 commit into from
Feb 21, 2020

Conversation

diogofscmariano
Copy link
Contributor

@diogofscmariano diogofscmariano commented Feb 18, 2020 •
edited
Loading

  • Typescript definitions added
  • Jest (with accessibility) tests added
  • Robot framework tests added
  • Samples added
  • Prevalidated by DS locally

JoaoEnesGoncalves
JoaoEnesGoncalves requested changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@JoaoEnesGoncalves JoaoEnesGoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

little things "coisinhas" that can be improved

automation/robot/storybook/core/tabs/tabs_keyboard_navigation.robot Outdated Show resolved Hide resolved
automation/robot/storybook/core/tabs/tabs_keyboard_navigation.robot Outdated Show resolved Hide resolved
automation/robot/storybook/core/tabs/tabs_structure.robot Outdated Show resolved Hide resolved
automation/robot/storybook/core/tabs/tabs_structure.robot Outdated Show resolved Hide resolved
automation/robot/storybook/core/tabs/tabs_structure.robot Show resolved Hide resolved
automation/robot/storybook/core/tabs/tabs_structure.robot Outdated Show resolved Hide resolved
automation/robot/storybook/core/tabs/tabs_structure.robot Outdated Show resolved Hide resolved
automation/robot/storybook/core/tabs/tabs_accessibility.robot Outdated Show resolved Hide resolved
@diogofscmariano
Copy link
Contributor Author

@JoaoEnesGoncalves @hugompfigueira issues/comments sent resolved. Thanks for the feedback

JoaoEnesGoncalves
JoaoEnesGoncalves requested changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@JoaoEnesGoncalves JoaoEnesGoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please look to the comments/review

automation/robot/storybook/core/tabs/tabs_structure.robot Outdated Show resolved Hide resolved
automation/robot/storybook/core/tabs/tabs_keyboard_navigation.robot Show resolved Hide resolved
automation/robot/storybook/core/tabs/tabs_keyboard_navigation.robot Outdated Show resolved Hide resolved
automation/robot/storybook/core/tabs/tabs_keyboard_navigation.robot Outdated Show resolved Hide resolved
automation/robot/storybook/core/tabs/tabs_keyboard_navigation.robot Outdated Show resolved Hide resolved
automation/robot/storybook/core/tabs/tabs_keyboard_navigation.robot Outdated Show resolved Hide resolved
automation/robot/storybook/core/tabs/tabs_keyboard_navigation.robot Outdated Show resolved Hide resolved
automation/robot/storybook/core/tabs/tabs_keyboard_navigation.robot Show resolved Hide resolved
JoaoEnesGoncalves
JoaoEnesGoncalves requested changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@JoaoEnesGoncalves JoaoEnesGoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please take look on comments

automation/robot/storybook/core/tabs/tabs_keyboard_navigation.robot Show resolved Hide resolved
automation/robot/storybook/core/tabs/tabs_keyboard_navigation.robot Outdated Show resolved Hide resolved
automation/robot/storybook/core/tabs/tabs_keyboard_navigation.robot Outdated Show resolved Hide resolved
automation/robot/storybook/core/tabs/tabs_keyboard_navigation.robot Outdated Show resolved Hide resolved
automation/robot/storybook/core/tabs/tabs_keyboard_navigation.robot Outdated Show resolved Hide resolved
automation/robot/storybook/core/tabs/tabs_keyboard_navigation.robot Outdated Show resolved Hide resolved
automation/robot/storybook/core/tabs/tabs_keyboard_navigation.robot Show resolved Hide resolved
@tiago-ssantos tiago-ssantos merged commit db7775b into lumada-design:alpha Feb 21, 2020
@diogofscmariano diogofscmariano deleted the #245 branch April 29, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zettca zettca zettca left review comments

@eliofreitas eliofreitas eliofreitas approved these changes

@JoaoEnesGoncalves JoaoEnesGoncalves JoaoEnesGoncalves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@diogofscmariano @zettca @JoaoEnesGoncalves @eliofreitas @tiago-ssantos