Cancelling "sn:willmove" won't make the default action be taken now

luke-chang · Mar 24, 2016 · 1da32d1 · 1da32d1
1 parent 59269fd
commit 1da32d1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -346,8 +346,6 @@ Fired when SpatialNavigation is about to move the focus.
 
 `direction` indicates the direction given by arrow keys or [`move()`](#spatialnavigationmovedirection-selector) method.
 
-**Note:** Cancelling this event makes the default action be taken normally, i.e. key events will be handled by browser as usual.
-
 #### `sn:willunfocus`
 
   + bubbles: `true`

diff --git a/spatial_navigation.js b/spatial_navigation.js
@@ -878,7 +878,6 @@
 
     var currentSectionId = getSectionId(currentFocusedElement);
     if (!currentSectionId) {
-      focusSection();
       return;
     }
 
@@ -888,11 +887,10 @@
       cause: 'keydown'
     };
 
-    if (!fireEvent(currentFocusedElement, 'willmove', willmoveProperties)) {
-      return;
+    if (fireEvent(currentFocusedElement, 'willmove', willmoveProperties)) {
+      focusNext(direction, currentFocusedElement, currentSectionId);
     }
 
-    focusNext(direction, currentFocusedElement, currentSectionId);
     return preventDefault();
   }