fix: Moving protocolify to dependencies #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also noticing this. |
|
@hagata I didn't notice any errors with Globby but it makes sense to list in dependencies since it's being used in the primary task. |
|
Thanks @shortdiv 😀 |
|
Thanks guys for the PR. I didn't notice this since I don't use grunt for quite a while now. |
lucalanca
added a commit
that referenced
this pull request
Nov 2, 2015
fix: Moving protocolify to dependencies
|
Available on 0.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an error when trying to run the grunt task that claimed that it couldn't find the module protocolify. Since it is being used in the primary grunt task, I'm moving it to the list of main dependencies so the module loads in the primary node_modules folder.