RFC: Syntax for read- and write- access to properties #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmccord
reviewed
Dec 7, 2023
Co-authored-by: Alexander McCord <[email protected]>
vegorov-rbx
reviewed
Dec 11, 2023
vegorov-rbx
reviewed
Dec 11, 2023
alexmccord
approved these changes
Jan 13, 2024
vegorov-rbx
added a commit
to luau-lang/luau
that referenced
this pull request
Jan 19, 2024
### What's changed? * Syntax for [read-only and write-only properties](luau-lang/rfcs#15) is now parsed, but is not yet supported in typechecking ### New Type Solver * `keyof` and `rawkeyof` type operators have been updated to match final text of the [RFC](luau-lang/rfcs#16) * Fixed issues with cyclic type families that were generated for mutable loop variables ### Native Code Generation * Fixed inference for number / vector operation that caused an unnecessary VM assist --- ### Internal Contributors Co-authored-by: Aaron Weiss <[email protected]> Co-authored-by: Andy Friesen <[email protected]> Co-authored-by: Lily Brown <[email protected]> Co-authored-by: Vyacheslav Egorov <[email protected]>
|
Just passing through and commenting here just as a random person with no context on the development of this feature :). Can we add to the documentation what this feature actually does? Also, a little unclear to me the use case and implications for allowing different read/write types. Seems like unnecessary complexity to support a niche use case I'm not familiar with so my first reaction is 👎 |
|
Specifically, it's unclear to me from the document what it means for a property of some type to be read/write only. I may have missed it. I did kind of tldr; the doc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered: https://github.com/luau-lang/rfcs/blob/master/docs/syntax-property-access-modifiers.md
Previous PRs: