Handle cyclically referenced declared classes #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume a change like this probably needs a FFlag? Let me know if so |
|
Hello! Yes, this certainly does need a FFlag. I think the change looks ok otherwise. |
|
I wasn't sure on the best way to cleanly separate the FFlag, so its a bit duplicated right now. Let me know if there are better ways |
|
review/merge, please? |
|
Coverage job seems to be broken, unrelated to this PR |
vegorov-rbx
reviewed
Nov 28, 2022
vegorov-rbx
approved these changes
Nov 28, 2022
Co-authored-by: vegorov-rbx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #631
Performs a "two pass" approach, where we first call
prototypeon the class definition.The prototype phase checks for errors and creates a base CTV for the class, which other types can then reference.
The second
checkphase fills it out with all the defined properties/methods