Convert Luau heap dumps to Chrome heap snapshots #1554
Conversation
tools/heapsnapshot.py
Outdated
| def getUniqueId(address): | ||
| # Addresses are hexadecimal strings | ||
| return int(address, 16) |
There was a problem hiding this comment.
This approach breaks the "reveal in summary" button (and potentially other small features). I suspect it's due to storing the id as an int within chrome's C++ layer and it overflows. I can resolve his by incrementing a counter instead to generate ids, but then the diff view would be broken as that relies on stable ids across snapshots. Maybe there's a hash function I can use here? I'm open to ideas.
There was a problem hiding this comment.
Added a todo for this as well. I'll follow-up with a PR if I find a nice hash function
| if "metatable" in obj: | ||
| edgeCount += 1 | ||
| addEdge([edgeTypeToMetaIndex["internal"], getStringSnapshotIndex(f'metatable ({obj["metatable"]})'), getNodeSnapshotIndex(obj["metatable"])]) | ||
| addNode([nodeTypeToMetaIndex["object"], getStringSnapshotIndex(name), getUniqueId(address), obj["size"], edgeCount, 0, 0]) |
There was a problem hiding this comment.
I was a bit lazy here wrt detecting "arrays" vs "objects" and just called them all objects. I'm not sure if there's much value in distinguishing them, but I'm open to reworking this to accommodate that if we want to
There was a problem hiding this comment.
I added a todo for now
|
This is awesome ⭐ ⭐ ⭐ ⭐ ⭐ |
Adds a script for (approximately) converting Luau heap dumps to Chrome heap snapshots. Useful for visually inspecting a heap dump within Chrome's UI.