Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync to upstream/release/645 #1440

Merged
merged 162 commits into from
Sep 27, 2024
Merged

Sync to upstream/release/645 #1440

merged 162 commits into from
Sep 27, 2024

Conversation

aatxe
Copy link
Collaborator

@aatxe aatxe commented Sep 27, 2024 •
edited
Loading

In this update, we continue to improve the overall stability of the new type solver. We're also shipping some early bits of two new features, one of the language and one of the analysis API: user-defined type functions and an incremental typechecking API.

If you use the new solver and want to use all new fixes included in this release, you have to reference an additional Luau flag:

LUAU_DYNAMIC_FASTINT(LuauTypeSolverRelease)

And set its value to 645:

DFInt::LuauTypeSolverRelease.value = 645; // Or a higher value for future updates

New Solver

  • Fix a crash where scopes are incorrectly accessed cross-module after they've been deallocated by appropriately zeroing out associated scope pointers for free types, generic types, table types, etc.
  • Fix a crash where we were incorrectly caching results for bound types in generalization.
  • Eliminated some unnecessary intermediate allocations in the constraint solver and type function infrastructure.
  • Built some initial groundwork for an incremental typecheck API for use by language servers.
  • Built an initial technical preview for user-defined type functions, more work still to come (including calling type functions from other type functions), but adventurous folks wanting to experiment with it can try it out by enabling FFlag::LuauUserDefinedTypeFunctionsSyntax and FFlag::LuauUserDefinedTypeFunctions in their local environment. Special thanks to @joonyoo181 who built up all the initial infrastructure for this during his internship!

Miscellaneous changes

Internal Contributors:

Co-authored-by: Aaron Weiss [email protected]
Co-authored-by: Hunter Goldstein [email protected]
Co-authored-by: Jeremy Yoo [email protected]
Co-authored-by: Vighnesh Vijay [email protected]
Co-authored-by: Vyacheslav Egorov [email protected]

aatxe and others added 30 commits November 3, 2023 12:47
@aatxe
Sync to upstream/release/602
a0b9950
@aatxe
Merge branch 'upstream' into merge
efe133a
@alexmccord
Sync to upstream/release/603
4b68791
@alexmccord
Merge branch 'master' into merge
6343648
@alexmccord
Merge branch 'heads/upstream' into merge
e57cbf6
@andyfriesen
Sync to upstream/release/604
674c6c4
@andyfriesen
Merge branch 'master' into merge
4320153
@andyfriesen
Merge branch 'upstream' into merge
2d4a544
@Vighnesh-V
VM
557e77a 
- Add SUBRK and DIVRK bytecode instructions
    - Enables future performance optimizations

Miscellaneous
- Small performance improvements to new non-strict mode
- Introduce more scripts for fuzzing
- Improcements to dataflow analysis
@Vighnesh-V
add stdint import
98d2db7
@Vighnesh-V @alexmccord
@andyfriesen @aviralg @dcope-rbx @AmaranthineCodices @vegorov-rbx
Merge branch 'upstream' into merge
e70eec0 
Co-authored-by: Alexander McCord <[email protected]>
Co-authored-by: Andy Friesen <[email protected]>
Co-authored-by: Aviral Goel <[email protected]>
Co-authored-by: David Cope <[email protected]>
Co-authored-by: Lily Brown <[email protected]>
Co-authored-by: Vyacheslav Egorov <[email protected]>
@Vighnesh-V
resolve one last merge conflict
7985414
@Vighnesh-V
can CI handle this?
c592f50
@Vighnesh-V
Sync to upstream/release/605
41669c9
@Vighnesh-V
remove tests for require by string
c932b8e
@Vighnesh-V
endif
c48ffc3
@vegorov-rbx
Sync to upstream/release/606
69728e8
@vegorov-rbx
Merge branch 'master' into merge
f5441d7
@vegorov-rbx
Merge branch 'upstream' into merge
6068432
@vegorov-rbx
Merge fix
139b169
@aatxe
Sync to upstream/release/607
f9c5cdd
@aatxe
Merge branch 'master' into merge
89090a1
@aatxe
Merge branch 'upstream' into merge
d622618
@aatxe
fix ubuntu build with import for cstddef in DenseHash
adea0f8
@Vighnesh-V
Merge branch 'upstream' of https://github.com/luau-lang/luau into ups…
d4883bf 
…tream
@Vighnesh-V
Sync to upstream/release/608
0d5c842
@Vighnesh-V
Merge branch 'master' into merge
74b0d00
@Vighnesh-V
Merge branch 'upstream' into merge
7932835
@Vighnesh-V
Sync to upstream/release/608
50b4779
@Vighnesh-V
Merge branch 'upstream' into merge
2f7509d
vegorov-rbx and others added 25 commits August 23, 2024 17:24
@vegorov-rbx
Sync to upstream/release/640
ebdbcb1
@vegorov-rbx
Merge branch 'master' into merge
caeba5a
@vegorov-rbx
Merge branch 'upstream' into merge
d414b56
@vegorov-rbx
Missing sync elements
5b9344a
@vegorov-rbx
Success, DCR mode no longer fails any tests
25db8ff
@aatxe
Sync release to upstream/release/641
a74031b
@aatxe
Merge branch 'master' into merge
78ae885
@aatxe
Merge branch 'upstream' into merge
f86f0a4
@andyfriesen
Sync to upstream/release/642
15557d8
@andyfriesen
Merge branch 'master' into merge
538b0c0
@andyfriesen
Merge branch 'upstream' into merge
ef8e1e3
@Vighnesh-V
Sync to upstream/release/643
cd27a20
@Vighnesh-V
Merge branch 'master' into merge
23e9fa5
@Vighnesh-V
Merge branch 'upstream' into merge
4df4a1d
@vegorov-rbx
Sync to upstream/release/644
a45eb2c
@vegorov-rbx
Merge branch 'master' into merge
d66e088
@vegorov-rbx
Merge branch 'upstream' into merge
0d6b70b
@vegorov-rbx
Smaller limit under ASAN for autocomplete_subtyping_recursion_limit
66ba360
@vegorov-rbx
Reduce it even more
9655780
@vegorov-rbx
Maybe reduce the base
0106dfa
@vegorov-rbx
Maybe more?
48f3c85
@vegorov-rbx
Fixed the issue
45594a5
@aatxe
Sync to upstream/release/645
7a7521a
@aatxe
Merge branch 'master' into merge
e888049
@aatxe
Merge branch 'upstream' into merge
a3da985
@joonyoo181
Copy link
Contributor

This is so exciting! I am super happy to have been given the chance to contribute 🙂

@aatxe aatxe requested a review from vegorov-rbx September 27, 2024 18:17
@aatxe aatxe merged commit 02241b6 into master Sep 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vegorov-rbx vegorov-rbx vegorov-rbx approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation error in TimeTrace.h when LUAU_ENABLE_TIME_TRACE enabled on ubuntu 20.04
7 participants
@aatxe @joonyoo181 @vegorov-rbx @alexmccord @andyfriesen @Vighnesh-V @AmaranthineCodices