Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
buffer
as a new type in both the old and new solvers.buffer
builtins to be a bit more generic to avoid platform-dependent error messages.Unifier
would copy some persistent types, tripping some internal assertions.if
statements with complex always-false conditionsNew type solver
never
, report errors at all uses of that parameter within that function.Luau::Set
to replacestd::unordered_set
to alleviate some poor allocation characteristics which was negatively affecting overall performance.if
statements or expressions, the resulting context are the common terms in both branches.Native codegen
buffer
builtins to its IR for x64 and A64.table.insert
by not inserting a table barrier if it is fastcalled with a constant.Internal Contributors
Co-authored-by: Aaron Weiss [email protected]
Co-authored-by: Alexander McCord [email protected]
Co-authored-by: Andy Friesen [email protected]
Co-authored-by: Arseny Kapoulkine [email protected]
Co-authored-by: Aviral Goel [email protected]
Co-authored-by: Lily Brown [email protected]
Co-authored-by: Vyacheslav Egorov [email protected]