Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New solver: String method calls cause incomplete number of argument errors, but do not in strict mode. #1507

Closed
ffrostfall opened this issue Nov 6, 2024 · 1 comment
Closed

New solver: String method calls cause incomplete number of argument errors, but do not in strict mode. #1507

ffrostfall opened this issue Nov 6, 2024 · 1 comment
Assignees
@aatxe
Labels
bug Something isn't working new solver This issue is specific to the new solver. non-strict

Comments

@ffrostfall
Copy link

ffrostfall commented Nov 6, 2024 •
edited
Loading

Minimal repro:
image

Strict mode result:
image
@ffrostfall ffrostfall added the bug Something isn't working label Nov 6, 2024
@aatxe aatxe added new solver This issue is specific to the new solver. non-strict labels Nov 6, 2024
@aatxe aatxe self-assigned this Nov 6, 2024
@aatxe
Copy link
Collaborator

aatxe commented Nov 7, 2024

Thanks for the report! This should be fixed in the 652 release!

@aatxe aatxe closed this as completed Nov 13, 2024
@vrn-sn vrn-sn mentioned this issue Nov 15, 2024
Merged
vrn-sn added a commit that referenced this issue Nov 15, 2024
@vrn-sn @aatxe
@andyfriesen @hgoldstein @Vighnesh-V
Sync to upstream/release/652 (#1525)
e905e30 
## What's new?

* Add support for mixed-mode type checking, which allows modules checked
in the old type solver to be checked and autocompleted by the new one.
* Generalize `RequireResolver` to support require-by-string semantics in
`luau-analyze`.
* Fix a bug in incremental autocomplete where `DefId`s associated with
index expressions were not correctly picked up.
* Fix a bug that prevented "complex" types in generic parameters (for
example, `local x: X<(() -> ())?>`).

### Issues fixed
* #1507
* #1518

---

Internal Contributors:

Co-authored-by: Aaron Weiss <[email protected]>
Co-authored-by: Andy Friesen <[email protected]>
Co-authored-by: Hunter Goldstein <[email protected]>
Co-authored-by: Varun Saini <[email protected]>
Co-authored-by: Vighnesh Vijay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aatxe aatxe

Labels
bug Something isn't working new solver This issue is specific to the new solver. non-strict
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aatxe @ffrostfall