Skip to content

Commit

Permalink
Add lua_cleartable (#678)
Browse files Browse the repository at this point in the history
To my understanding lua_cleartable does not need GC barriers because
it's only removing elements and not modifying the stack. But I'm not a
GC expert so please correct if I'm wrong.

resolves #672

Co-authored-by: Petri Häkkinen <[email protected]>
  • Loading branch information
petrihakkinen and Petri Häkkinen authored Sep 22, 2022
1 parent bdf7d8c commit fc48719
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 0 deletions.
2 changes: 2 additions & 0 deletions VM/include/lua.h
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,8 @@ LUA_API void lua_setuserdatadtor(lua_State* L, int tag, void (*dtor)(lua_State*,

LUA_API void lua_clonefunction(lua_State* L, int idx);

LUA_API void lua_cleartable(lua_State* L, int idx);

/*
** reference system, can be used to pin objects
*/
Expand Down
10 changes: 10 additions & 0 deletions VM/src/lapi.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1376,6 +1376,16 @@ void lua_clonefunction(lua_State* L, int idx)
api_incr_top(L);
}

void lua_cleartable(lua_State* L, int idx)
{
StkId t = index2addr(L, idx);
api_check(L, ttistable(t));
Table* tt = hvalue(t);
if (tt->readonly)
luaG_runerror(L, "Attempt to modify a readonly table");
luaH_clear(tt);
}

lua_Callbacks* lua_callbacks(lua_State* L)
{
return &L->global->cb;
Expand Down
5 changes: 5 additions & 0 deletions tests/Conformance.test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -778,6 +778,11 @@ TEST_CASE("ApiTables")
CHECK(strcmp(lua_tostring(L, -1), "test") == 0);
lua_pop(L, 1);

// lua_cleartable
lua_cleartable(L, -1);
lua_pushnil(L);
CHECK(lua_next(L, -2) == 0);

lua_pop(L, 1);
}

Expand Down

0 comments on commit fc48719

Please sign in to comment.