Replace monitorJSON.name with monitorJSON.pathName in all notification providers (where applicable) #5485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n providers (where applicable) As noted in louislam#3798, it would be great to have the alarm notification include the full monitor path. This was done for Mattermost in louislam#3801, but not for the other notification providers. This commit replaces all other trivial occurences of monitorJSON.name with monitorJSON.pathName.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #3798, it would be great to have the alarm notification include the full monitor path. This was done for Mattermost in #3801, but not for all the other notification providers. This commit replaces all other trivial occurences of monitorJSON.name with monitorJSON.pathName.
I only really care about the Discord notification providers, but I also changed all the other low hanging fruits I could find. Only Discord is personally tested by me as I do not have access to the other providers. If you consider this too sketchy to merge, I will gladly drop the changes to the other providers.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #3798
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)