Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the save bar of the maintenance menu #5385

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

cyril59310
Copy link
Contributor

@cyril59310 cyril59310 commented Nov 26, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

I noticed that, in some cases, when the list of probes is displayed downward, the save bar overlaps this menu, which can be quite inconvenient for selecting the different probes.

Fixes #(issue)
I have therefore made sure that this menu no longer overlaps the list.

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • User interface (UI)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Before

image
IMG_0386

after

image
IMG_0387

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@cyril59310 cyril59310 changed the title fix save bottom maintenance Fix the save bar of the maintenance menu Nov 26, 2024
@CommanderStorm
Copy link
Collaborator

Thanks for the contribution (seems like a simple enough fix to include even this late in the cycle) 👍🏻

@CommanderStorm CommanderStorm added this to the 2.0.0-beta.1 milestone Nov 27, 2024
@CommanderStorm CommanderStorm merged commit c0fe669 into louislam:master Nov 27, 2024
19 checks passed
@cyril59310 cyril59310 deleted the fix-maintenance branch November 28, 2024 10:51
Zaid-maker pushed a commit to Zaid-maker/uptime-kuma that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants