Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the timeout value #5352

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Fix the timeout value #5352

merged 1 commit into from
Nov 19, 2024

Conversation

Ionys320
Copy link
Contributor

@Ionys320 Ionys320 commented Nov 17, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

When editing a monitor, the timeout default value is automatically set. While the monitor is not saved, the value previously set by the user is used (even if another value is shown in the UI). But still, the correct value wans't defined. This was caused by f059d54, which were changing the timeout when monitor type were changed.

Fixes #5337

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • User interface (UI)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How this is usually checked for the other defaults is that it is only set for undefined => falsy values.

For this one, changing on monitor-type change makes also sense => this impl is better

@CommanderStorm CommanderStorm added this to the 2.0.0-beta.1 milestone Nov 19, 2024
@CommanderStorm CommanderStorm merged commit 4228dd0 into louislam:master Nov 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nightly2 - Change to HTTP(s) monitor Request Timeout does not persist
2 participants