Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix not setting a default for json monitor operations #5295

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

CommanderStorm
Copy link
Collaborator

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #5294

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings

Screenshots (if any)

now:

pre-migrate post-migrate
before_pr image

@CommanderStorm CommanderStorm added this to the 2.0.0-beta.1 milestone Oct 31, 2024
@CommanderStorm CommanderStorm changed the title added a migration fix not setting a default for json monitor operations Oct 31, 2024
@CommanderStorm CommanderStorm added the releaseblocker blocking bugs encountered with a new release label Oct 31, 2024
@louislam louislam merged commit a7407a1 into louislam:master Nov 5, 2024
19 checks passed
@CommanderStorm CommanderStorm deleted the fix-json_path_op branch November 5, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
releaseblocker blocking bugs encountered with a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to v2 beta, JSON monitors are broken until re saved
2 participants