-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add docker service availability monitoring #5215
base: master
Are you sure you want to change the base?
feat: add docker service availability monitoring #5215
Conversation
9f988bc
to
bd719d9
Compare
Introduces Docker service availability to monitor uptime and status of Docker services alongside existing types. Updates the database schema to support "docker_service". Enhances the user interface to allow configuration of Docker service parameters within the monitor setup. This change allows for more granular monitoring capabilities by checking the running state of services in a Docker environment. Relates to implementing extended Docker monitoring functionalities. implements louislam#5214 Signed-off-by: Bryan Gonzalez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets go back one step to the conceptual level how this should be done:
We are currently in the migration towards a few things that are relevant for this PR:
- we are migrating from the ginormous
monior.js
to more maintainable monitoring types. See reddis for a similar PR.
=> This PR needs to use the newer variant. - having two really close monitors is not ideal for users. Please merge this with the docker monitor unless there is a reason this should not happen
- For monitors, we need testcases (f.ex. via testcontainers) to prevent stupid regressions in the future. If this is not possible, that is another story, but I think it likely is => we should try to do so.
See feat: addRabbitMQ
monitor #5199 for a PR on how to use testcontainers - Please have a look at this file and check if the newer conditional approach can work for this monitor
I have changed this to a draft to communicate the early stage of the PR to others better. Feel free to change once this fits better. ^^
If you have any trouble with one of the comments above, feel free to comment.
Please clarify what you're asking of me. I only wanted to contribute a simple addition to the platform because I personally have need of it. But I'll consider contributing the refactor if the scope is clear. |
forgot tag: @CommanderStorm |
Yes, please migrate to the newer monitoring type structure.
For you it might, I don't think it is for other users (f.ex. me). If you look at this file, I think we can have a much nicer experience with a bit more effort ^^
For checking if the docker monitor can monitor docker containers (spawned via a testcontaier), there also does not need to be one.
That is an alternative, but lets try to do it properly first |
I would really love this feature, it would be good if container hashes change |
I'm still tracking this, but I haven't had time lately to do the refactor. I'm happy to do it, but I won't feel bad if someone beats me to it. I just need to find the time. |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Introduces Docker service availability to monitor uptime and status of Docker services alongside existing types. Updates the database schema to support "docker_service". Enhances the user interface to allow configuration of Docker service parameters within the monitor setup.
This change allows for more granular monitoring capabilities by checking the running state of services in a Docker environment.
Relates to implementing extended Docker monitoring functionalities.
implements #5214
Type of change
Checklist
Screenshots (if any)
@louislam