feat: keephq notification provider #4722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderStorm
requested changes
Apr 28, 2024
| @@ -0,0 +1,47 @@ | |||
| const NotificationProvider = require("./notification-provider"); | |||
| const axios = require("axios"); | |||
| const FormData = require("form-data"); | |||
There was a problem hiding this comment.
(in general, not only this PR)
I think we can remove this dependency in v2.0, as we have upgraded to the minimum supported node version to 18:
There was a problem hiding this comment.
Removed this as it is no longer required
|
@CommanderStorm |
|
@CommanderStorm Click to expand2024-04-30.14-08-08.mp4 |
CommanderStorm
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support to configure Keep as notification provider
Type of change
Checklist
Screenshots (if any)