Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored the Can I create a pull request for Uptime Kuma section #4545

Merged
merged 2 commits into from
Mar 3, 2024

Conversation

CommanderStorm
Copy link
Collaborator

@CommanderStorm CommanderStorm commented Mar 1, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

This PR refactors Can I create a pull request for Uptime Kuma?:

  • to give more actionable advice on how to create new monitoring/notification types
  • what types of PRs exist and how they should be handled
  • how they can be merged. ⇐ This one might be controversial. We can obviously revert this change ^^

Related to #4525

Type of change

Please delete any options that are not relevant.

  • Other
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings

Screenshots (if any)

Before After
image image

@CommanderStorm CommanderStorm requested a review from louislam March 1, 2024 17:46
@louislam louislam merged commit 4c683da into louislam:master Mar 3, 2024
5 checks passed
@CommanderStorm CommanderStorm deleted the contribution-guide-2 branch March 3, 2024 12:25
@CommanderStorm CommanderStorm added this to the 2.0.0 milestone Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants