Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Incorrect handling of status page not found #4537

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

chakflying
Copy link
Collaborator

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #4535

StatusPageData should always return something, so there is no need to check for its existence. sending HTTP Error response was however missing if the status page itself is not found.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

@chakflying chakflying added area:status-page Everything related to the status page area:api concearning the api or automation labels Feb 27, 2024
@louislam louislam merged commit c7b8bb9 into louislam:master Feb 28, 2024
17 checks passed
@Saibamen
Copy link
Contributor

Should be backported to 1.23.X

@chakflying chakflying deleted the fix/status-page-not-found branch April 6, 2024 14:24
@CommanderStorm CommanderStorm added this to the 2.0.0 milestone Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api concearning the api or automation area:status-page Everything related to the status page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API requests for non-existent status pages hang forever
4 participants