-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Heii On-Call Notification Provider #4485
Add Heii On-Call Notification Provider #4485
Conversation
Co-authored-by: Frank Elsinga <[email protected]>
@CommanderStorm Thanks for the review. I believe I have addressed all your concerns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I changed the formatting of the code a bit to be closer to the other notification providers.
Could you review the changes I added in cc00011?
Other than that, I am happy with the current code.
I am unsure if we should change the translations in this context as suggested in #4485 (review) => I am going to leave this up to you to either accept/resolve
Co-authored-by: Frank Elsinga <[email protected]>
@CommanderStorm awesome! Accepted your changes. Thanks so much for the review. |
Fix misspelled "Trigger"
@CommanderStorm let me know if there is anything else I can do to help this get merged. I'd like to work on a guide for setting up Uptime Kuma with Heii On-Call, and would like to have this in before its published. |
Actually there is: Other than that I would be happy to merge this into the upcoming v2.0 release. |
Testing screenshot has been added. |
Thanks for the notification provider! |
Tick the checkbox if you understand [x]:
Add notification provider for Heii On-Call.
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)
Setup Notification
Events
UP
DOWN