Merge pull request #1136 from chakflying/fix/prometheus-on-delete

Fix: Remove prometheus metrics on delete [Test needed]
louislam · Mar 27, 2022 · be88351 · be88351
2 parents 34a0b54 + 1bbd744
commit be88351
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/server/model/monitor.js b/server/model/monitor.js
@@ -477,6 +477,12 @@ class Monitor extends BeanModel {
     stop() {
         clearTimeout(this.heartbeatInterval);
         this.isStop = true;
+
+        this.prometheus().remove();
+    }
+
+    prometheus() {
+        return new Prometheus(this);
     }
 
     /**

diff --git a/server/prometheus.js b/server/prometheus.js
@@ -86,6 +86,16 @@ class Prometheus {
         }
     }
 
+    remove() {
+        try {
+            monitor_cert_days_remaining.remove(this.monitorLabelValues);
+            monitor_cert_is_valid.remove(this.monitorLabelValues);
+            monitor_response_time.remove(this.monitorLabelValues);
+            monitor_status.remove(this.monitorLabelValues);
+        } catch (e) {
+            console.error(e);
+        }
+    }
 }
 
 module.exports = {

diff --git a/server/server.js b/server/server.js
@@ -579,6 +579,9 @@ exports.entryPage = "dashboard";
                     throw new Error("Permission denied.");
                 }
 
+                // Reset Prometheus labels
+                monitorList[monitor.id]?.prometheus()?.remove();
+
                 bean.name = monitor.name;
                 bean.type = monitor.type;
                 bean.url = monitor.url;