Use asciidoctor and asciidoctor-pdf as dependencies #25
Conversation
|
The thing is that the html page should be published in GH pages, so no
absolute paths should be added
El El mar, 29 oct 2019 a las 16:43, Guillaume Grossetie <
[email protected]> escribió:
***@***.**** commented on this pull request.
------------------------------
In src/quarkus-cheat-sheet/quarkus-cheat-sheet.html
<#25 (comment)>
:
> @@ -6615,7 +6615,7 @@ <h3>Authors :</h3>
</div>
<div class="author-bio">0.26.1</div>
-<img src="./redhat/assets/by-nc-sa.png"/>
+<img src="/home/guillaume/workspace/opensource/temp/quarkus-cheat-sheet/src/quarkus-cheat-sheet/template/assets/by-nc-sa.png"/>
I'm using {__dirname} in the template.js to resolve the absolute path of
the script:
<link href="${__dirname}/assets/style.css" rel="stylesheet">
So the path is actually relative to the template.js file.
I don't think we should versionned this "temporary" file. It's useful for
debugging purpose but it's really a "transient state".
If you want to keep the HTML files versionned I can revert this change
even though we might run into troubles if the HTML file is generated
somewhere else.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#25?email_source=notifications&email_token=AALSMYPYHS42INL3FJWTN7TQRBK2PA5CNFSM4JGKCC72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJSSREI#discussion_r340158979>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALSMYJMUPFNAPAQQ32PYKLQRBK2PANCNFSM4JGKCC7Q>
.
--
Enviat amb Gmail Mobile
|
I think you want to publish the HTML page of the cheat sheet using the default HTML 5 converter from Asciidoctor core right? The HTML page produced by Asciidoctor PDF (JS) will not be easy to read because the content won't be split by pages. In fact, the content will content will fill the first column until the bottom of the document (so you will have to scroll all the way down to read the first column, then go back to the top of the page for the second column, and again for the third column). The HTML file generated by Asciidoctor PDF (JS) is designed to be a transient state. If it was possible to generate a PDF without writing an HTML file on the disk I would have done that. Anyway I don't want to disrupt too much things at once, so I will revert this change. |
|
I completely agree with you, I think that waiting a bit of time and see how all these changes go for now it is a good strategy. |
ggrossetie
force-pushed
the
issue-24-asciidoctor-dependency
branch
from
5543d3b to
cf4494b
Compare
If you want to give it a try on your machine.
node_modulesnpm inpm run generate(or./generate.sh)resolves #24