Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Asciidoctor PDF (JS) as a dependency #24

Open
ggrossetie opened this issue Oct 29, 2019 · 2 comments
Open

Use Asciidoctor PDF (JS) as a dependency #24

ggrossetie opened this issue Oct 29, 2019 · 2 comments

Comments

@ggrossetie
Copy link
Collaborator

This project was initiated as a fork of Asciidoctor PDF (JS) because (I believe that) at the time there was no release.
Since then the project is now more stable and I think we should use Asciidoctor PDF as a dependency:

$ npm i -g asciidoctor asciidoctor-pdf

It would allow to remove a lot of code 💥

@lordofthejars
Copy link
Owner

humm yes it might work, the good thing about how it is now it is that it is self-contained, on the other way you need to have everything installed to make it work. But yes maybe it could be a good next step.

@ggrossetie
Copy link
Collaborator Author

humm yes it might work, the good thing about how it is now it is that it is self-contained, on the other way you need to have everything installed to make it work.

Currently, you still need to run npm i to install the dependencies before you can use ./bin/asciidoctor-pdf.

But yes maybe it could be a good next step.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants