Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use description list instead of table #16

Open
ggrossetie opened this issue Oct 28, 2019 · 3 comments
Open

Use description list instead of table #16

ggrossetie opened this issue Oct 28, 2019 · 3 comments

Comments

@ggrossetie
Copy link
Collaborator

I don't see how the following table can fit in a column:

Prefix is `quarkus.log`.

|===	
| Property | Default | Description
a|`category."<category-name>".level`
a|`INFO`
a|Minimum level category.

a|`level`
a|`INFO`
a|Default minimum level.

a|`console.enable`
a|`true`
a|Console logging enabled.

a|`console.format`
a|`%d{yyyy-MM-dd HH:mm:ss,SSS} %-5p [%c{3.}] (%t) %s%e%n`
a|Format pattern to use for logging.
|====

We should maybe use a description list instead:

`category."<category-name>".level`:: Minimum level category (default: `INFO`)

`level`:: Default minimum level (default: `INFO`)

`console.enabled`:: Console logging enabled (default: `true`)

`console.format`:: Format pattern to use for logging. Default value: +
`%d{yyyy-MM-dd HH:mm:ss,SSS} %-5p [%c{3.}] (%t) %s%e%n`
@lordofthejars
Copy link
Owner

Yes probably you are right but now changing all columns might be a neverend story. I think that the new ones could be done in this way, and change step by step the others.

@ggrossetie
Copy link
Collaborator Author

Here's an example:

Table Description list
table dt
table-long dt-long

In the end it takes less vertical space and, in my opinion, it's easier to read/parse.
@lordofthejars What do you think?

As a side note, I think I've found an error in this table, the default value of console.color (allow color rendering) is INFO? I think it should be a Boolean value right?

@lordofthejars
Copy link
Owner

lordofthejars commented Oct 30, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants