-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Calling other APIs Page #1766
Comments
I think this section should be updated. Considering that now we have a basic |
#2128 and #1766 are about the same docs page. @nabdelgadir , could you please take a look and see if there are duplicate requirements and whether we can close one and continue the discussion on one of them? Thanks. |
From what @nabdelgadir described: |
Looking at the content in https://loopback.io/doc/en/lb4/Calling-other-APIs-and-web-services.html, it seems to be that we no longer need to install the service-proxy directly? I'm thinking that we should rewrite this page as below:
@strongloop/loopback-maintainers, what do you think? |
Description / Steps to reproduce / Feature proposal
As I was working on loopbackio/loopback4-example-shopping#20 I was referencing our docs https://loopback.io/doc/en/lb4/Calling-other-APIs-and-web-services.html and I found it to be a bit confusing ...
lb4 datasource
prompts for abaseUrl
which is not respected byloopback-connector-rest
.@serviceProxy
decorator usage doesn't explain what it takes in -- is the string the name of the datasource (what I got from code), name of service, etc. and how is it determined by the booter?Get an instance of your controller
section is at a really weird place and confusing. What's the intent of this section?Make service proxies easier to test
, the code should be reviewed. For example, the following is wrong. -- we are initializing the service instead of letting DI do it. This entire section seems a bit incomplete to me.Current Behavior
Expected Behavior
See Reporting Issues for more tips on writing good issues
The text was updated successfully, but these errors were encountered: