-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support python3.12 #395
Support python3.12 #395
Conversation
Fix ci errors on python3.11
@long2ice Workflow needs to be modified to support running CI on Python 3.12 |
I do not agree with just changing to import to v1, a proper transition should be made to the current version on Pydantic. |
Thank you, I understand this, but this PR is to support Python3.12, not to support Pydanic v2. Regarding the support for Pydantic V2, I think this should be opened as a separate issue. |
@mkdir700 @Wolfhound905 Support for Python 3.12 will be part of the upcoming Right now, the package dependencies specify either Pydantic The For now I'm going to close this PR in favour of #463, not least because it changes current Pydantic behaviour at the same time as supporting Python 3.12. Feel free to re-open if you disagree. |
closes: #392