Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support python3.12 #395

Closed
wants to merge 13 commits into from
Closed

Conversation

mkdir700
Copy link
Contributor

@mkdir700 mkdir700 commented Feb 3, 2024

closes: #392

@mkdir700
Copy link
Contributor Author

mkdir700 commented Feb 3, 2024

@long2ice Workflow needs to be modified to support running CI on Python 3.12

@Wolfhound905
Copy link

I do not agree with just changing to import to v1, a proper transition should be made to the current version on Pydantic.

@mkdir700
Copy link
Contributor Author

mkdir700 commented Apr 24, 2024

Thank you, I understand this, but this PR is to support Python3.12, not to support Pydanic v2.

Regarding the support for Pydantic V2, I think this should be opened as a separate issue.

@vicchi
Copy link
Collaborator

vicchi commented Nov 10, 2024

@mkdir700 @Wolfhound905 Support for Python 3.12 will be part of the upcoming 0.3.0 release, see #462

Right now, the package dependencies specify either Pydantic v1 or v2.

The 1.0.0 release will deprecate Pydantic v1 support entirely, see #463

For now I'm going to close this PR in favour of #463, not least because it changes current Pydantic behaviour at the same time as supporting Python 3.12. Feel free to re-open if you disagree.

@vicchi vicchi closed this Nov 10, 2024
@vicchi vicchi added duplicate This issue or pull request already exists wontfix This will not be worked on labels Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants