Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocustBadStatusCode without url param in fasthttp #2944

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

swaalt
Copy link
Contributor

@swaalt swaalt commented Oct 16, 2024

a new function _verify_status was created and a LocustBadStatusCode class is sent as a response to the function which removes the url leaving only the code.

@cyberw
Copy link
Collaborator

cyberw commented Oct 17, 2024

👍 just add a test case to test_fasthttpuser (or add some validation it to some existing one) and format using ruff and I’ll merge.

@cyberw
Copy link
Collaborator

cyberw commented Oct 17, 2024

Hmm... looks like every Python version failed, that's a bit worrying, but may still be irrelevant.

Can you write the test this way instead?

def test_error_message(self):

@cyberw
Copy link
Collaborator

cyberw commented Oct 17, 2024

No I didnt mean the name, I meant the way of testing :)

@cyberw cyberw merged commit 0f506c5 into locustio:master Oct 18, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants