Add Logging to download_locustfile_from_master #2749
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This one is a bit tricky, the argument parser happens before the log setup, so we don't have access to the same log levels as we would in the rest of the application. I also didn't want to have tons of messages logging for no reason, so I placed the messaging outside of the while loop.
The problem with having the message outside of the while loop, is that we don't yet know if connecting to master failed or not (so it shouldn't really be a warning). However, without logging being setup it seems we only have warning level logs. So the warning level is a bit of a lie, but it does at least provide some feedback that the master needs to be connected in order for the worker to start
Fixes #2748