Ensure spawning_complete only happens once on workers #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 24, 2024 18:05
…wning_complete before #2728, but now that only happens once *all* workers have finished)
…n the event happening)
2 tasks
mquinnfd
pushed a commit
to mquinnfd/locust
that referenced
this pull request
May 28, 2024
…wning_complete before locustio#2728, but now that only happens once *all* workers have finished)
cyberw
added a commit
that referenced
this pull request
Jul 5, 2024
* remove generated front end bundle * add poetry and front end dist to vcs ignore * update build system manifest for poetry - Modify pyproject.toml file for poetry build system - Adds build script to generate front end as part of poetry build - Adds renaming script to remove architecture info from wheel file name - Updates Makefile to call the correct build steps with `make build` * chmod on release renaming script * re-add wheel extension to changed file name * ensure vsc autoversioning plugin * ensure vcs auto versioning plugin * revert vscode settings * add local dev install command * add version file to package output * only include poetry lock in sdist * run build setup as one shell * check if yarn is installed before building * deny poetry venvs creation * remove poetry installation and just check for poetry and yarn * update URLs for related info * Ensure spawning_complete happens only once on workers. * Update various test cases for new spawning_complete behavior. * Simplify additional test cases using the new get_messages function. * Set worker_state to 'running' in start_worker (this used to be by spawning_complete before #2728, but now that only happens once *all* workers have finished) * Simplify semaphore_wait example * Reverse accidental change * Update WorkerRunner.state when spawn cycle is done (it used to rely on the event happening) * Further simplify example * Rewrite confusing error messages if someone accesses an HTTP Web UI using https * Convert report time to locale time * Update HTML report tests * Use requests 2.32.2 or higher for Python 3.12, fixes #2555 * Upgrade Sphinx to latest version * Add to extensions also? Mentioned in https://sphinx-rtd-theme.readthedocs.io/en/stable/installing.html#how-to-install-and-use-the-theme * hash anchors in setup docs pages * testing version of pep440 generator * remove dist * ignore dist contents * include changes to pyproject from main - requests version * Remove unnecessary python https://sphinx-rtd-theme.readthedocs.io/en/stable/installing.html * Downgrade docutils to officially supported * Restore theme name * Fix ruff error * Rename css options * Conform to style * Add timestamp to chart tooltip * Add zoom to echarts * Update test * Fix empty timestamp formatting * Round total_avg_response_time from history * Reduce CSV_STATS_FLUSH_INTERVAL_SEC to 5 seconds by default (more reasonable in the time of SSD:s :) and remove it from the docs (because it will only rarely need to be adjusted, and increasing it is a very unusual need) * Dial back the API TOC * doc formatting fix * Modify timestamp generation to remove deprecation warning * Add newline at the end of the file * Fix incorrect error message detection for https requests introduced in 84ada19 * update build system manifest for poetry - Modify pyproject.toml file for poetry build system - Adds build script to generate front end as part of poetry build - Adds renaming script to remove architecture info from wheel file name - Updates Makefile to call the correct build steps with `make build` * remove merge object * test commit distance * jinja templating for format number * simple vesion formatting * take a stab at updating workflows for poetry * might as well add discussions forum while I'm here * add docs serve command to makefile * developing locust docs page * make readme and pyproject align in terms of URLs * remove unused py version in wheel * adjust dockerfile for poetry build * add dev dependency group * docs dependencies * docs dependencies and readme * venv for tests * RTD config for versioning * rtd step * don't run the build script on the remote * rtd * tests and tox * tox fixes * progress on CI runners locally * skip front end build * in-progress * run on remotes not my poor laptop * run on remotes not my poor laptop * ruff and mypy version * yarn timeout for windows, update mypy * windows plz * windows plz * add mypy as a dev dependency * tests * testing if this is actually a shell thing * increase fetch depth for dunamai versioning * I know what the problem is at least * test windows * tox install * revert vs code settings * remove oneshell directive from old installation process * Update maintainers and authors * move web ui to correct location * update file exclusions * skip fe build in fail-fast test * pin some version dependencies * update tox version * add wheel renaming to prepublishing steps --------- Co-authored-by: Lars Holmberg <[email protected]> Co-authored-by: Andrew Baldwin <[email protected]> Co-authored-by: Sam Wright <[email protected]> Co-authored-by: Lars Holmberg <[email protected]> Co-authored-by: JavierUhagón <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since 2.0 the behaviour has been really strange: spawning_complete on workers was fired after every cycle instead of only once.
This restores the functionality by having the masters spawning_complete event send a message to workers.
Technically a breaking change.