Update Stats History on HTML Report #2709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
|
Some time we should add automated tests for this kind of thing. But not necessarily today :) |
|
Definitely I think it's a good idea. I can look into it at some point with something like Playwright or Selenium. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Because of
HISTORY_STATS_INTERVAL_SEC, we will only have history starting after 5 seconds of run time. Unlikerequest_statsinweb.py, we rely on history to display the charts in the HTML report. This is why the dashboard shows the results correctly in the dashboard but not in the reportProposal
Expose a new function
update_stats_historythat can be called when generating the HTML report. This will ensure that the stats history list is up to date before returning the reportFixes #2706