Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update grpc example, because grpc gevent issue has been fixed #1834

Merged
merged 1 commit into from
Aug 1, 2021

Conversation

cyberw
Copy link
Collaborator

@cyberw cyberw commented Jul 31, 2021

@beandrad Make sense?

@cyberw
Copy link
Collaborator Author

cyberw commented Jul 31, 2021

@beandrad I havent really been able to test it, I just noticed that the issue has supposedly been fixed (while I was doing some documentation updates)

@beandrad
Copy link

beandrad commented Aug 1, 2021

Hi @cyberw! Nice, my changed in grpc has been finally released! I've just tested your changes, and the example is working fine with grpc 1.39.0.

@cyberw
Copy link
Collaborator Author

cyberw commented Aug 1, 2021

Hah, awesome! I didnt see your name on the PR :) 👍👍

@cyberw cyberw merged commit 975d3aa into master Aug 1, 2021
@cyberw cyberw deleted the grpc-gevent-issue-has-been-fixed branch March 22, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants