Improve IsValidOp design and performance #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pramsey
added a commit
to pramsey/geos
that referenced
this pull request
Jun 21, 2021
Merged
strk
pushed a commit
to libgeos/geos
that referenced
this pull request
Jul 6, 2021
Port locationtech/jts#743, Improve IsValidOp design and performance Port locationtech/jts#755, Add IndexedNestedPolygonTester to IsValidOp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades
IsValidOpto provide simpler, clearer design and better performance. The semantics are unchanged.GeometryGraphis removed as a dependency. This reduces theIsValidOpcode dependencies to a minimum.Performance is improved by simpler and faster noding, and better short-circuiting.