WKTParser extension support #3244
Conversation
pomadchin
changed the title
pomadchin
force-pushed
the
feature/wkt-extension-proj4
branch
from
a5a3b18 to
3e29f41
Compare
pomadchin
force-pushed
the
feature/wkt-extension-proj4
branch
from
3e29f41 to
c7181ea
Compare
pomadchin
changed the title
| } | ||
|
|
||
| case class ExtensionProj4(value: String) extends Extension { |
There was a problem hiding this comment.
I'm still wondering was it a good idea to make it a part of the parsing DSL or not.
There was a problem hiding this comment.
Can you describe why or why not? I think I'm lacking some project context to know more.
There was a problem hiding this comment.
I'm also wondering, mb there is a better name for Extention that is just anything and not Proj4?
There was a problem hiding this comment.
Including as part of the DSL seems fine, its what we do for all the other things we need to parse, so that feels consistent at least.
IDK about better names. All the other parsers match the names being parsed out, like Parser[GeocCS] looks for GEOCCS[]. So what's here is consistent with the current naming convention. Kinda annoying that its such a generic word that could be confused in other contexts, but it seems pretty well isolated here at first glance, so 🤷
pomadchin
force-pushed
the
feature/wkt-extension-proj4
branch
from
40f11e9 to
f5efae9
Compare
Overview
Checklist
Closes #3241