Histogram Equalization #1668
Histogram Equalization #1668
Conversation
jamesmcclain
force-pushed
the
feature/histogram-equalization
branch
2 times, most recently
from
0fa772a to
e3c3fce
Compare
| private def _T(cellType: CellType, cdf: Array[(Double, Double)])(x: Double): Double = { | ||
| val i = java.util.Arrays.binarySearch(cdf, (x, 0.0), cmp) | ||
| val bits = cellType.bits | ||
| val cdf_x = |
There was a problem hiding this comment.
More verbose variable names or comments would make this code a lot easier to read.
|
|
||
|
|
||
| trait MultibandEqualizationMethods extends MethodExtensions[MultibandTile] { | ||
| def equalize(histograms: Array[StreamingHistogram]): MultibandTile = HistogramEqualization(self, histograms) |
There was a problem hiding this comment.
Can this only work with streaming histograms, or our histogram type in general?
There was a problem hiding this comment.
It currently relies on the ability to get the CDF associated with the histogram directly form it. I could add that capability to the other histogram types, but only StreamingHistogram has it right now.
|
I would be very curious to see the same sort of set of screenshots for RGB imagery, for instance a before-and-after landsat w/ histogram equalization on each band. |
jamesmcclain
force-pushed
the
feature/histogram-equalization
branch
from
e3c3fce to
6c0379d
Compare
jamesmcclain
force-pushed
the
feature/histogram-equalization
branch
from
6c0379d to
65f69ba
Compare
|
I have updated the PR comment with some pictures demonstrating the functionality on a multiband (non-landsat) image. |
jamesmcclain
force-pushed
the
feature/histogram-equalization
branch
2 times, most recently
from
438743a to
df5c637
Compare
|
The restriction to |
|
@jamesmcclain good stuff. Can you update to master? |
jamesmcclain
force-pushed
the
feature/histogram-equalization
branch
from
df5c637 to
641da7f
Compare
The various histogram equalization functionality had previously been tied to StreamingHistogram, now it works with Histogram[T].
jamesmcclain
force-pushed
the
feature/histogram-equalization
branch
from
641da7f to
2dc4e4d
Compare
Still Needs:
Singleband
Unequalized:
Equalized (signed values being treated as unsigned by GIMP):
Equalized (signed values being treated as signed by GeoServer):
Multiband
Original:
GIMP histogram equalization (Colors -> Auto -> Equalize)
Histogram equalization using this PR
Original bands:
Equalized bands (using this PR):
