Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for node v12 #299

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Drop support for node v12 #299

merged 1 commit into from
Oct 18, 2021

Conversation

lo1tuma
Copy link
Owner

@lo1tuma lo1tuma commented Oct 15, 2021

No description provided.

@lo1tuma lo1tuma requested a review from screendriver October 15, 2021 16:00
@lo1tuma lo1tuma merged commit d1c421b into master Oct 18, 2021
@lo1tuma lo1tuma deleted the drop-n12 branch October 18, 2021 09:15
@lo1tuma lo1tuma restored the drop-n12 branch October 18, 2021 09:15
@lo1tuma lo1tuma deleted the drop-n12 branch October 18, 2021 09:15
@niksy
Copy link

niksy commented Nov 8, 2021

@lo1tuma should this be related to #298 (comment)? If Node 12 support is dropped, maybe we should release new major version?

@lo1tuma
Copy link
Owner Author

lo1tuma commented Nov 12, 2021

@niksy yes this change will be released in the next major version. I don’t think it is related to #298.

@WikiRik
Copy link

WikiRik commented Dec 30, 2021

@lo1tuma can I ask why Node 12 completely was dropped? It's still in maintenance LTS until 2022-04-30 and eslint 8 supports ^12.22.0 || ^14.17.0 || >=16.0.0. Wouldn't it be better to link the support to that?

@lo1tuma
Copy link
Owner Author

lo1tuma commented Dec 30, 2021

@WikiRik usually I consider to drop support for older node versions every time I’m planning to make a new major-version release. The EoL for node 12 is in only 4 months, so I think it is reasonable for people who still want to use node 12 until then to also use an older version of eslint-plugin-mocha.

@WikiRik
Copy link

WikiRik commented Dec 30, 2021

@lo1tuma I can see that. Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants