Fix no-setup-in-describe to allow suite config call via computed memb…

…er expression
lo1tuma · Sep 10, 2019 · 64d1db4 · 64d1db4
1 parent 0d838d5
commit 64d1db4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/lib/util/ast.js b/lib/util/ast.js
@@ -47,7 +47,7 @@ function isHookCall(node) {
 function isSuiteConfigExpression(node) {
     return node.type === 'MemberExpression' &&
       node.object.type === 'ThisExpression' &&
-      suiteConfig.indexOf(node.property.name) !== -1;
+      suiteConfig.indexOf(getPropertyName(node.property)) !== -1;
 }
 
 function isSuiteConfigCall(node) {

diff --git a/test/rules/no-setup-in-describe.js b/test/rules/no-setup-in-describe.js
@@ -22,13 +22,15 @@ ruleTester.run('no-setup-in-describe', rule, {
         'describe("", function () { this.slow(1); it(); })',
         'describe("", function () { this.timeout(1); it(); })',
         'describe("", function () { this.retries(1); it(); })',
+        'describe("", function () { this["retries"](1); it(); })',
         'describe("", function () { it("", function () { b(); }); })',
         'describe("", function () { it("", function () { a.b; }); })',
         'describe("", function () { it("", function () { a[b]; }); })',
         'describe("", function () { it("", function () { a["b"]; }); })',
         'describe("", function () { it("", function () { this.slow(1); }); })',
         'describe("", function () { it("", function () { this.timeout(1); }); })',
         'describe("", function () { it("", function () { this.retries(1); }); })',
+        'describe("", function () { it("", function () { this["retries"](1); }); })',
         'describe("", function () { function a() { b(); }; it(); })',
         'describe("", function () { function a() { b.c; }; it(); })',
         'describe("", function () { afterEach(function() { b(); }); it(); })',
@@ -142,17 +144,6 @@ ruleTester.run('no-setup-in-describe', rule, {
                 line: 1,
                 column: 28
             } ]
-        }, {
-            code: 'describe("", function () { this["retries"](); });',
-            errors: [ {
-                message: 'Unexpected function call in describe block.',
-                line: 1,
-                column: 28
-            }, {
-                message: memberExpressionError,
-                line: 1,
-                column: 28
-            } ]
         }, {
             code: 'foo("", function () { a.b; });',
             settings: {