Optimization for MF #17
Open
+94
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thwu1
changed the title
iojw
reviewed
Jul 20, 2024
| use_proj, | ||
| dim=128, | ||
| num_models=64, | ||
| text_dim=768, |
There was a problem hiding this comment.
Could we automatically set the text dim based on the selected embeddings?
| num_classes=1, | ||
| use_proj=True, | ||
| embedding_model="all-mpnet-base-v2", |
There was a problem hiding this comment.
Maybe better to use OpenAI's embeddings by default to preserve our existing behavior? I'll add some docs to describe the different options here.
| num_classes=1, | ||
| use_proj=True, | ||
| collapse_linear=False, | ||
| embedding_model="all-mpnet-base-v2", |
There was a problem hiding this comment.
I think it would be better if we didn't set any default args here and specify default args only in routers.py so that it's easier to keep track of router configs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9 I added precompution for collapsing three linear transformations without modifying the loading part. @iojw Do you want to do a speed test?