chore(runner): remove duplicate pynvml dep #319
Conversation
rickstaa
force-pushed
the
remove_duplicate_deps
branch
from
fa47156 to
0b1fb07
Compare
This commit removes the duplicate pynvml dependency.
rickstaa
force-pushed
the
remove_duplicate_deps
branch
from
0b1fb07 to
2ff0f77
Compare
| @@ -35,14 +35,14 @@ RUN cd /comfyui/custom_nodes && \ | |||
| cd ComfyUI-Misc-Effects && \ | |||
| git checkout c6b360c78611134c3723388170475eb4898ff6b7 | |||
|
|
|||
| RUN pip install torch==2.5.1 torchvision torchaudio tqdm nvidia-ml-py==12.560.30 | |||
There was a problem hiding this comment.
@leszko The only scenario where hardcoding this in the Dockerfile seems necessary is when a dependency chain installs an incorrect version of nvidia-ml-py before the requirements.txt file is processed. If this is the case we should remove it from the requirements so that we don't have two definitions that can conflict. Can you check that it works without hardcoding it in the docker?
|
@victorges this was a part duplicate of #323. Maybe we can add the comment so engineers know that the library is already included under a different name. |
|
@rickstaa hmmm that's super weird then, do you have an idea why were we getting errors when importing pynvml on some images like liveportrait? |
|
I get the same error with streamdiffusion too (running on tensordoc) e.g. |
Yeah, then I suggest not merging this PR, because it will break our environments. We need to research and fix these dependencies, but it's not the highest priority right now |
This pull request removes the duplicate pynvml dependency.