Add timestamps to TranscriptionSegment #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiroshihorie
approved these changes
Aug 10, 2024
lukasIO
reviewed
Aug 10, 2024
| TranscriptionSegment(id: segment.id, | ||
| text: segment.text, | ||
| language: segment.language, | ||
| firstReceivedTime: _state.transcriptionReceivedTimes[segment.id] ?? Date(), |
There was a problem hiding this comment.
are you expecting both startTime and firstReceivedTime to have separate purposes?
Otherwise we could simply override startTime with firstReceivedTime?
There was a problem hiding this comment.
I don't know what startTime and endTime are intended for but I assumed they'd be in a track-local timekeeping system? They don't have a Date type - it's UInt64. When we do eventually add support for them from the server, would that cause a breaking change if we'd overloaded them already in the clients?
lukasIO
reviewed
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tracking of transcription receipt times which simplifies the consumption of this feature. I also removed startTime and endTime from the version we expose, since neither is used yet at the protocol level.
The new fields are
firstReceivedTimeandlastReceivedTime.I tried this out in my sample project and it really simplified things. Now I can implement a very basic real-time chat thread without needing multiple data structures or new types. The only thing that still requires extra bookkeeping is tracking participant name, etc, since TranscriptionSegment lives under TrackPublication and Participant, and we don't denormalize the Participant id down the chain.
See the associated commit in my docs PR for a visual of how this simplifies basic uses