refactor(typing): Remove "unpacking" of annotated_types
#3716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofin
approved these changes
Sep 3, 2024
cofin
force-pushed
the
fix-annotated-types-test
branch
from
855c331 to
bac6f78
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3716 +/- ##
==========================================
- Coverage 98.29% 98.29% -0.01%
==========================================
Files 330 330
Lines 15125 15122 -3
Branches 2403 2401 -2
==========================================
- Hits 14867 14864 -3
- Misses 116 117 +1
+ Partials 142 141 -1 ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some improperly constructed test cases, where annotated types were constructed as
Annotated[str, annotated_types.LowerCase]instead ofannotated_types.LowerCase[str], which lead to code that handled this incorrect case.I stumbled across this during another refactor, where I wrote a correct test case that passed without this special code, while the old case was failing.