Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move getToken to BaseApi #370

Closed
Rineee opened this issue Jul 25, 2022 · 2 comments
Closed

move getToken to BaseApi #370

Rineee opened this issue Jul 25, 2022 · 2 comments
Assignees
Milestone

Comments

@Rineee
Copy link
Contributor

Rineee commented Jul 25, 2022

URL:
user:
expected behaviour:
behaviour:
important screensize:
device & browser:
Comment/Question:
We now need the token authentication for every request we are making, so instead of getting the token in the fetch methods, we should move that to BaseApi

Screenshot?

@hello-kathi
Copy link

@Rineee is that important for testing the app? Then I would put it into the milestone for the next sprint.

@Rineee
Copy link
Contributor Author

Rineee commented Feb 7, 2023

It is not important for testing, more of a refactor thing, but still would be good if we did that, so if there is place for it in the milestone, it would be good :)

@hello-kathi hello-kathi added this to the Next in 2023 milestone Feb 8, 2023
@Rineee Rineee self-assigned this Mar 7, 2023
Rineee pushed a commit that referenced this issue Mar 14, 2023
philli-m pushed a commit that referenced this issue Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants