-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pm 2023 5 deps bootstrap #591
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philli-m
force-pushed
the
pm-2023-5-deps-bootstrap
branch
4 times, most recently
from
May 11, 2023 08:44
a26f404
to
5523867
Compare
philli-m
force-pushed
the
pm-2023-5-deps-bootstrap
branch
from
May 11, 2023 09:15
5523867
to
4ec48c1
Compare
goapunk
reviewed
May 11, 2023
…ts and variable names
philli-m
force-pushed
the
pm-2023-5-deps-bootstrap
branch
from
May 11, 2023 10:34
4ec48c1
to
819d0a0
Compare
goapunk
reviewed
May 11, 2023
goapunk
reviewed
May 11, 2023
goapunk
reviewed
May 11, 2023
goapunk
reviewed
May 11, 2023
goapunk
requested changes
May 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really nice! just some minor things we should probably fix
philli-m
force-pushed
the
pm-2023-5-deps-bootstrap
branch
2 times, most recently
from
May 15, 2023 09:57
f8b9067
to
9f64607
Compare
… to work with new BS and custom js update to use correct trigger classes
philli-m
force-pushed
the
pm-2023-5-deps-bootstrap
branch
from
May 15, 2023 14:22
9f64607
to
b817fca
Compare
goapunk
approved these changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.