Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps/home/blocks: update teasers to require colour choice fixes #905 #913

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

philli-m
Copy link
Contributor

@philli-m philli-m commented Oct 31, 2023

after discussion with @maxliqd we also decided to save confusion updating the block labels would be advantageous too, as migrations were needed for the fix I added them to same PR

@philli-m philli-m force-pushed the pm-2023-10-styling-fixes branch from 3d7f7d8 to 98a1424 Compare November 1, 2023 13:14
@philli-m philli-m changed the title WIP apps/home/blocks: update teaser to require colour choice fixes #905 WIP apps/home/blocks: update teasers to require colour choice fixes #905 Nov 2, 2023
@philli-m philli-m force-pushed the pm-2023-10-styling-fixes branch from 98a1424 to 625c6a4 Compare November 2, 2023 13:40
@philli-m philli-m requested review from goapunk and m4ra November 2, 2023 13:41
@philli-m
Copy link
Contributor Author

philli-m commented Nov 2, 2023

migrations don't conflict with django update so pushed also needs translations, will leave rest to you guys

@philli-m philli-m changed the title WIP apps/home/blocks: update teasers to require colour choice fixes #905 apps/home/blocks: update teasers to require colour choice fixes #905 Nov 2, 2023
apps/home/blocks.py Outdated Show resolved Hide resolved
@philli-m philli-m force-pushed the pm-2023-10-styling-fixes branch from 8b0a785 to 0e02fe1 Compare November 2, 2023 14:58
@philli-m philli-m requested a review from goapunk November 2, 2023 14:59
@philli-m philli-m force-pushed the pm-2023-10-styling-fixes branch from 0e02fe1 to 89d4eb5 Compare November 2, 2023 15:05
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goapunk goapunk enabled auto-merge (rebase) November 2, 2023 15:06
@goapunk goapunk merged commit 0916870 into main Nov 2, 2023
2 checks passed
@goapunk goapunk deleted the pm-2023-10-styling-fixes branch November 2, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants