[7774] Make wagtail blocks available on different page types #884
Conversation
hom3mad3
changed the title
| ('video_block', apps_blocks.VideoBlock()), | ||
| ('text_with_image', apps_blocks.TextWithImageBlock()), | ||
| ('faq_accordion', apps_blocks.FaqBlock()), | ||
| ('quote', apps_blocks.QuoteBlock()), |
There was a problem hiding this comment.
is trailing comma a thing?
There was a problem hiding this comment.
it doesn't throw any errors like with json (at least not in wagtail) but if I notice them I normally clean them up
There was a problem hiding this comment.
ok, so i think i will leave it, as i notice the entire code is like that
| ('video_block', apps_blocks.VideoBlock()), | ||
| ('text_with_image', apps_blocks.TextWithImageBlock()), | ||
| ('faq_accordion', apps_blocks.FaqBlock()), | ||
| ('quote', apps_blocks.QuoteBlock()), |
There was a problem hiding this comment.
it doesn't throw any errors like with json (at least not in wagtail) but if I notice them I normally clean them up
| @@ -0,0 +1,47 @@ | |||
| # Generated by Django 3.2.19 on 2023-10-25 17:36 | |||
There was a problem hiding this comment.
although having a history of different named migrations locally is fine, when merging to main we should merge them with the correct name, you can use git rebase -i mainto add the name changes to the relevant commits so main only ever has a record of the correct name, does that make sense?
There was a problem hiding this comment.
@philli-m updated respective commits with correct names.
can you please have a look and confirm if i got it right? 🙈
|
@hom3mad3 also another fun thing about working with wagtail and it's constant need for migrations is that it's always a good idea to se if anything has been merged with migrations since you pulled, as the wagtail update just got merged you will need to delete your migrations you made for this pr and pull the most recent main and rebase and install and remake your migrations (sorry) this is because migrations on main must always be sequential and can't be doubled up as they always rely on previous one |
hom3mad3
force-pushed
the
mr-2023-10-wagtail-blocks
branch
from
2935fe4 to
86b4f5e
Compare
hom3mad3
force-pushed
the
mr-2023-10-wagtail-blocks
branch
from
c90405e to
e0bf1d3
Compare
hom3mad3
changed the title
No description provided.