Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release mb v2412.2 #1736

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,15 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
This project (not yet) adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## mb-v2412.2

### Changed
- change rating icons to thumbs in map

### Fixed
- hide accessible text for rating buttons to only be visible for screen readers


## mb-v2412.1

### Fixed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ exports[`Comment Component renders comment with creator and comment text 1`] = `
Likes
</span>
<span
class="aural"
class="a4-sr-only"
>
Click to like
</span>
Expand All @@ -116,7 +116,7 @@ exports[`Comment Component renders comment with creator and comment text 1`] = `
Dislikes
</span>
<span
class="aural"
class="a4-sr-only"
>
Click to dislike
</span>
Expand Down Expand Up @@ -383,7 +383,7 @@ exports[`Comment Component renders comment with creator and comment text 1`] = `
Likes
</span>
<span
class="aural"
class="a4-sr-only"
>
Click to like
</span>
Expand All @@ -407,7 +407,7 @@ exports[`Comment Component renders comment with creator and comment text 1`] = `
Dislikes
</span>
<span
class="aural"
class="a4-sr-only"
>
Click to dislike
</span>
Expand Down Expand Up @@ -736,7 +736,7 @@ exports[`Comment Component renders comment with moderator badge 1`] = `
Likes
</span>
<span
class="aural"
class="a4-sr-only"
>
Click to like
</span>
Expand All @@ -760,7 +760,7 @@ exports[`Comment Component renders comment with moderator badge 1`] = `
Dislikes
</span>
<span
class="aural"
class="a4-sr-only"
>
Click to dislike
</span>
Expand Down Expand Up @@ -1032,7 +1032,7 @@ exports[`Comment Component renders comment with moderator badge 1`] = `
Likes
</span>
<span
class="aural"
class="a4-sr-only"
>
Click to like
</span>
Expand All @@ -1056,7 +1056,7 @@ exports[`Comment Component renders comment with moderator badge 1`] = `
Dislikes
</span>
<span
class="aural"
class="a4-sr-only"
>
Click to dislike
</span>
Expand Down
4 changes: 2 additions & 2 deletions adhocracy4/maps/static/a4maps/a4maps_display_points.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,10 @@ function init () {

function getRatings (feature) {
return '<span class="map-popup-upvotes">' +
feature.properties.positive_rating_count + ' <i class="fa fa-chevron-up" aria-hidden="true"></i>' +
feature.properties.positive_rating_count + ' <i class="fa fa-thumbs-up" aria-hidden="true"></i>' +
'</span>' +
'<span class="map-popup-downvotes">' +
feature.properties.negative_rating_count + ' <i class="fa fa-chevron-down" aria-hidden="true"></i>' +
feature.properties.negative_rating_count + ' <i class="fa fa-thumbs-down" aria-hidden="true"></i>' +
'</span>'
}

Expand Down
2 changes: 1 addition & 1 deletion adhocracy4/ratings/static/ratings/RatingButton.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const RatingButton = ({
type="button"
>
{children}
<span className="aural">{type === 'up' ? translations.upvote : translations.downvote}</span>
<span className="a4-sr-only">{type === 'up' ? translations.upvote : translations.downvote}</span>
</button>
)
}
Expand Down