static/Alert.jsx: refactor #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hom3mad3
commented
Dec 17, 2024
| @@ -309,8 +310,7 @@ export default class Comment extends React.Component { | |||
|
|
|||
| return ( | |||
| <li> | |||
| {this.props.displayNotification && | |||
| <div className="alert alert--success a4-comments__success-notification"><i className="fas fa-check" /> {translated.successMessage}</div>} | |||
There was a problem hiding this comment.
this icon is such an edge case that i removed it (also inconsistently used)
vellip
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the Alert component to improve semantics by removing unnecessary attributes, such as aria-live, and appropriately handling role="status" for success and warning messages, while using role="alert" for critical notifications. Reverted back to the
.alertclass to prevent unintended impacts on other repositories and reduce overhead.